Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke: add image conversion time in benchmark #1508

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

#1460

Details

Add ConversionElapsed in benchmark. ConversionElapsed can express the performance of nydus image conversion.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested review from a team as code owners December 7, 2023 04:56
@Desiki-high Desiki-high requested review from bergwolf, liubogithub and gaius-qi and removed request for a team December 7, 2023 04:56
@Desiki-high Desiki-high changed the title Smoke/bench convert elapsed smoke: add image conversion time in benchmark Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1508 (80be9e6) into master (e12416e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1508   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files         129      129           
  Lines       44158    44158           
  Branches    44158    44158           
=======================================
  Hits        27702    27702           
  Misses      15088    15088           
  Partials     1368     1368           

see 1 file with indirect coverage changes

@Desiki-high Desiki-high force-pushed the smoke/bench-convert-elapsed branch 2 times, most recently from ff89851 to ba4a21c Compare December 7, 2023 05:12
ConversionElapsed can express the performance of accelerated image conversion.

Signed-off-by: Yadong Ding <[email protected]>
@imeoer imeoer merged commit a3e60c0 into dragonflyoss:master Dec 8, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants